Re: SEO Urls contain /en-gb ?
You missed the point, there is no clear way to remove it, that is the default language...
Jump to post- Tue Aug 29, 2023 5:04 am
- Replies 12
- Views 3013
Re: SEO Urls contain /en-gb ?
ok i worked out that you can fix the // bug easily , as found that it was intended to be a valid option to leave keyword blank to hide a parameter
https://github.com/opencart/opencart/pull/12651
"Leave blank if you just want to remove the perimeter."
- Mon Aug 28, 2023 6:02 pm
- Replies 12
- Views 3013
Re: SEO Urls contain /en-gb ?
this didnt work, it did get rid of the en-gb, but it left the un-seo query such as /product/product_name?language=en-gbspeakspaceAdmin wrote: ↑Fri Aug 25, 2023 5:29 amGo to Design > SEO url. Find the en-gb one and delete that little sucker.
if i just clear the keyword, its closer, but you get 2 // Jump to post
- Mon Aug 28, 2023 4:06 pm
- Replies 12
- Views 3013
Re: SEO Urls contain /en-gb ?
Oh, that is neat if it's that simple! Will try it later
Jump to post- Fri Aug 25, 2023 7:12 am
- Replies 12
- Views 3013
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
I read your extension page knoxville, but dont see any mention of the variant issue ?
Generally id like to add that i started this thread to discuss the variant/mast add to cart issue (if anyone is wants), not just complain about Daniel 
- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Wed Jul 19, 2023 5:00 pm
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
While it's nice to hear from someone else for a change, I actually mention the same fix already in the referenced issue in my opening post. I wasn't really looking for solutions, I was making this thread to highlight Daniels inability to discuss what in my opinion is clearly a mistake / missed oppor...
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Mon Jul 17, 2023 6:16 pm
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
I still don't get why you saying just that adds anything to the discussion? You are just repeating what I have already stated in the first post...
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Mon Jul 17, 2023 9:55 am
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
I still dont think YOU understand my opening post and the reason for this thread. There is NO commit you talk about. There is a git issue I initially created before this thread to try and deal with it that way, but Daniel just disregarded me completely and closed it as he does commonly. There is no ...
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Mon Jul 17, 2023 6:08 am
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
Im just saying if you cant understand the issue by reading my opening post and asking any question here or making comments then this aint the topic for you...
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Sun Jul 16, 2023 5:21 pm
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
that is unnecessary and overkill, its simple 2 example reasons:
- there is a master_id field in the order_product table
- adding master looses all variant override details which then cant be used for checkout/reorder/order history/order notification the list goes on
- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Sun Jul 16, 2023 5:37 am
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
I have, master is the same as my version, it hasnt been fixed because Daniel doesnt think its a bug, yet there is proof that he's wrong. Please read my opening post.
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Sat Jul 15, 2023 9:54 am
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
That's the problem, the default (in my opinion incorrect) behaviour is to add the master instead of the variant to the cart.
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Sat Jul 15, 2023 6:18 am
- Replies 24
- Views 7634
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
Are you sure? As I thought I checked latest github and it seemed like it had not changed since my version? I might have to check a 4022 install Jump to post
- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Fri Jul 14, 2023 5:53 am
- Replies 24
- Views 7634
Re: [SOLVED] Submitting sitemap feed to Google Search Console issue
or
Code: Select all
curl https://domain.com.au/index.php?route=extension/feed/google_sitemap > /home/user/public_html/sitemap.xml- Fri Jul 07, 2023 6:37 pm
- Replies 12
- Views 3179
Re: Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
I believe variants are a OC4 thing, im running OC4.0.1.1 but will upgrade asap, but my suggestion applies right up to latest commit on master.
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Thu Jul 06, 2023 4:47 am
- Replies 24
- Views 7634
Re: Install lib via Composer
actually this is how ive done it in the past, so no big deal, what i was talking about is using the system composer install, but i think it retrospect its likely best to run my own composer install.
Jump to post- Sat Jul 01, 2023 6:50 pm
- Replies 9
- Views 3064
Re: Install lib via Composer
extension_id=17 , wow you've had that a while 
ill have to try that, thanks ! I downloaded your extension to see how you did it.
- Sat Jul 01, 2023 6:41 pm
- Replies 9
- Views 3064
Re: Install lib via Composer
I did that (update composer.json or use require command) but you still have to edit vendor.php which is a pain and seems pointless when there is a perfectly good autoloader available, plus its not just the lib you want, its all its dependencies, plus their functions.... I tried creating a 2nd vendor...
Jump to post- Sat Jul 01, 2023 4:40 am
- Replies 9
- Views 3064
Re: Install lib via Composer
thanks for this, id found the composer vendor folder in storage and wondered if i could use it, installed my library with require , added use lines to the class but class not found when trying to new() in .... thank you thankyou , just edit system/vendor maybe oc should just autoload ?? (chongshengd...
Jump to post- Fri Jun 30, 2023 1:43 pm
- Replies 9
- Views 3064
Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
Hi, Ive been investigating the variant system and using it our website to create different models assigned to different option configs. During this I noticed that, as the title suggests, when you add a variant to the cart, the oc system does a switch and adds the parent/master instead, but with the ...
Jump to post- Feedback
- Adding Variant to cart, adds the Master instead, but should it add the variant instead or optionally ??
- Thu Jun 01, 2023 4:10 am
- Replies 24
- Views 7634
