Post by straightlight » Tue Apr 16, 2019 6:13 am

Does this mean that we still need to confirm and fix it ourselves?
That is the case for every OC releases.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by paulfeakins » Mon Apr 29, 2019 4:33 pm

HAO wrote:
Mon Apr 15, 2019 5:11 pm
The development team should not let developers and users handle the problem of debugging.
Even a company as big as Microsoft does to some extent:

"Remember when Microsoft's disastrous Windows 10 October Update removed entire user folders like documents and photos? Or the Surface Book 2 owners who had their systems rendered useless from update KB4467682? This happened because users were manually checking for updates and not waiting for the update to get automatically triggered. Why is this a big deal? Because the average Windows user believes that's a safe way to get their system updates as soon as possible. Unfortunately, it's the exact opposite, and Microsoft's Corporate President for Windows has admitted it in a recent blog post."
https://www.forbes.com/sites/jasonevang ... e-updates/

UK OpenCart Hosting | OpenCart Audits | OpenCart Support - please email info@antropy.co.uk


User avatar
Guru Member
Online

Posts

Joined
Mon Aug 22, 2011 11:01 pm
Location - London Gatwick, United Kingdom

Post by papegaai01 » Mon Jul 08, 2019 7:41 pm

Hi,

I have installed VQmod 2.6.4 on a fresh Opencart 3.0.3.2 but after installation i cannot log in to the admin and my site is not loading.

Any ideas?

Active Member

Posts

Joined
Fri Jul 29, 2011 6:08 pm

Post by straightlight » Tue Jul 09, 2019 4:23 am

papegaai01 wrote:
Mon Jul 08, 2019 7:41 pm
Hi,

I have installed VQmod 2.6.4 on a fresh Opencart 3.0.3.2 but after installation i cannot log in to the admin and my site is not loading.

Any ideas?
I don't see how relevant it's related to a core issue. This topic is for the core.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by doducanh » Wed Jul 31, 2019 5:43 pm

duplicate layout - opencart 3.0.3.2

Newbie

Posts

Joined
Thu Nov 23, 2017 4:28 pm

Post by straightlight » Thu Aug 01, 2019 3:41 am

doducanh wrote:
Wed Jul 31, 2019 5:43 pm
duplicate layout - opencart 3.0.3.2
No mention about installed extensions or whether this video originates from a fresh install.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by HAO » Fri Aug 02, 2019 12:31 am

paulfeakins wrote:
Mon Apr 29, 2019 4:33 pm
Even a company as big as Microsoft does to some extent:

"Remember when Microsoft's disastrous Windows 10 October Update removed entire user folders like documents and photos? Or the Surface Book 2 owners who had their systems rendered useless from update KB4467682? This happened because users were manually checking for updates and not waiting for the update to get automatically triggered. Why is this a big deal? Because the average Windows user believes that's a safe way to get their system updates as soon as possible. Unfortunately, it's the exact opposite, and Microsoft's Corporate President for Windows has admitted it in a recent blog post."
https://www.forbes.com/sites/jasonevang ... e-updates/
Even so, I think this is still necessary.

Because you can imagine, if there are patches and code changes.txt guide at the same time, I think I can minimize the possibility of this problem.

If you don't understand the program, But if you trust the development team, you can use the "replace file" method to complete the update.

If you understand the program, you can read the code changes.txt to manually complete the code change, This is like the operation mode of phpBB 19 years ago.

I have to say that it is a very accurate and reliable open source code program SOP, Therefore, I think it is necessary to carry out such a release at the same time.

Because it’s very important to discuss the content of the changes in each step, What do you think?

HAO
Active Member

Posts

Joined
Fri Jun 03, 2011 2:52 pm

Post by straightlight » Fri Aug 02, 2019 6:56 pm

Because it’s very important to discuss the content of the changes in each step, What do you think?
This is what this forum is all about. However, while feature requests does have its own forum section, only those that will be considered might be implemented in a future OC release eventually since Change Management are not only about users requests but also based on Industrial changes from service providers.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by doducanh » Sat Aug 03, 2019 3:13 pm

No mention about installed extensions or whether this video originates from a fresh install.
I use a new installation, have not installed any extension software.

Newbie

Posts

Joined
Thu Nov 23, 2017 4:28 pm

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by JNeuhoff » Sun Aug 04, 2019 8:16 pm

doducanh wrote:
Sat Aug 03, 2019 3:13 pm
No mention about installed extensions or whether this video originates from a fresh install.
I use a new installation, have not installed any extension software.
Nobody is able to reproduce your error. You are not telling us the whole story here. This is not a bug in Opencart.

Try to do a complete fresh installation of OC 3.0.3.2 , without 3rd party extensions, and then test adding layouts again.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by doducanh » Mon Aug 05, 2019 11:09 pm

Nobody is able to reproduce your error. You are not telling us the whole story here. This is not a bug in Opencart.

Try to do a complete fresh installation of OC 3.0.3.2 , without 3rd party extensions, and then test adding layouts again.
I have reinstalled and the results remain the same.

Newbie

Posts

Joined
Thu Nov 23, 2017 4:28 pm

Post by by mona » Mon Aug 05, 2019 11:55 pm

This must be really annoying, but .. I use OC3.0.3.2 all the time, especially working with the layouts.
If this were me, I would try the following
1. Download a new OC 3.0.3.2 installation from the OC site
2. Use a completely new database
3. Make sure no files or folders exist anywhere when I upload and install onto the server.
Just a suggestion ..
@xxxvirusxxx
What browser?
And try this fix
https://github.com/opencart/opencart/issues/7495
I have just tried on Chrome - still working perfectly - but I do not have windows

DISCLAIMER:
You should not modify core files .. if you would like to donate a cup of coffee I will write it in a modification for you.


https://www.youtube.com/watch?v=zXIxDoCRc84


User avatar
Expert Member

Posts

Joined
Mon Jun 10, 2019 9:31 am

Post by Davidev » Wed Feb 12, 2020 11:23 pm

It's good idea instead of using ocmods to modify the core or events (events it's closely of method and not inside method, correct? ), implement hooks and add various anchor points in the code for create or update easy your plugin or module? For exemple in wp it's good approce for code scalabilty.
Sorry for my poor english :crazy:

-----------------------------------------------------------------------------------
My Extension ;) | Ios / macos Dev | SEO (it)


User avatar
Newbie

Posts

Joined
Sun Jul 09, 2017 5:05 pm
Location - Italy

Post by ont » Sat Feb 15, 2020 11:28 pm

There is a mistypo in github master branch in file admin/catalog/marketplace/installer.php line 158 is addInstall and should be addExtensionInstall, same error on install file line 481 deleteInstall method should be deleteExtensionInstall.

ont
Newbie

Posts

Joined
Sat Feb 15, 2020 3:04 am

Post by straightlight » Sat Feb 15, 2020 11:49 pm

ont wrote:
Sat Feb 15, 2020 11:28 pm
There is a mistypo in github master branch in file admin/catalog/marketplace/installer.php line 158 is addInstall and should be addExtensionInstall, same error on install file line 481 deleteInstall method should be deleteExtensionInstall.
Regarding the master branch, please report those issues in a new / already existing opened commit in the Opencart Github community.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by moshair » Fri Apr 03, 2020 5:58 am

I noticed that the added custom fields doesn't exists on the order (invoice) print page. So I should write them on that printed page.
It is important to include the custom fields I added like Building Number, Street, and Apartment No.) because I also give that printed invoice the delivery man.

New member

Posts

Joined
Sun Jul 21, 2019 3:27 pm

Post by straightlight » Fri Apr 03, 2020 5:59 am

moshair wrote:
Fri Apr 03, 2020 5:58 am
I noticed that the added custom fields doesn't exists on the order (invoice) print page. So I should write them on that printed page.
It is important to include the custom fields I added like Building Number, Street, and Apartment No.) because I also give that printed invoice the delivery man.
OC version?

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by moshair » Fri Apr 03, 2020 6:05 am

straightlight wrote:
Fri Apr 03, 2020 5:59 am
moshair wrote:
Fri Apr 03, 2020 5:58 am
I noticed that the added custom fields doesn't exists on the order (invoice) print page. So I should write them on that printed page.
It is important to include the custom fields I added like Building Number, Street, and Apartment No.) because I also give that printed invoice the delivery man.
OC version?
Thank you, it is 3.0.3.2

New member

Posts

Joined
Sun Jul 21, 2019 3:27 pm

Post by straightlight » Fri Apr 03, 2020 6:51 am

Take note that adding custom fields into the invoice may result dealing with split invoice template between pages. Only use the following if considering to use split pages if you cannot configure your printer driver to a fit landscape.

In admin/controller/sale/order.php file, in the invoice() method,

find:

Code: Select all

foreach ($orders as $order_id) {
add above:

Code: Select all

$this->load->model('customer/custom_field');
Then, find - still in the invoice() method:

Code: Select all

$data['orders'][] = array(
add above:

Code: Select all

$account_custom_fields = array();

				$filter_data = array(
					'sort'  => 'cf.sort_order',
					'order' => 'ASC'
				);

				$custom_fields = $this->model_customer_custom_field->getCustomFields($filter_data);

				foreach ($custom_fields as $custom_field) {
					if ($custom_field['location'] == 'account' && isset($order_info['custom_field'][$custom_field['custom_field_id']])) {
						if ($custom_field['type'] == 'select' || $custom_field['type'] == 'radio') {
							$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($order_info['custom_field'][$custom_field['custom_field_id']]);

							if ($custom_field_value_info) {
								$account_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $custom_field_value_info['name']
								);
							}
						}

						if ($custom_field['type'] == 'checkbox' && is_array($order_info['custom_field'][$custom_field['custom_field_id']])) {
							foreach ($order_info['custom_field'][$custom_field['custom_field_id']] as $custom_field_value_id) {
								$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($custom_field_value_id);

								if ($custom_field_value_info) {
									$account_custom_fields[] = array(
										'name'  => $custom_field['name'],
										'value' => $custom_field_value_info['name']
									);
								}
							}
						}

						if ($custom_field['type'] == 'text' || $custom_field['type'] == 'textarea' || $custom_field['type'] == 'file' || $custom_field['type'] == 'date' || $custom_field['type'] == 'datetime' || $custom_field['type'] == 'time') {
							$account_custom_fields[] = array(
								'name'  => $custom_field['name'],
								'value' => $order_info['custom_field'][$custom_field['custom_field_id']]
							);
						}

						if ($custom_field['type'] == 'file') {
							$upload_info = $this->model_tool_upload->getUploadByCode($order_info['custom_field'][$custom_field['custom_field_id']]);

							if ($upload_info) {
								$account_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $upload_info['name']
								);
							}
						}
					}
				}

				// Custom fields
				$payment_custom_fields = array();

				foreach ($custom_fields as $custom_field) {
					if ($custom_field['location'] == 'address' && isset($order_info['payment_custom_field'][$custom_field['custom_field_id']])) {
						if ($custom_field['type'] == 'select' || $custom_field['type'] == 'radio') {
							$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($order_info['payment_custom_field'][$custom_field['custom_field_id']]);

							if ($custom_field_value_info) {
								$payment_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $custom_field_value_info['name'],
									'sort_order' => $custom_field['sort_order']
								);
							}
						}

						if ($custom_field['type'] == 'checkbox' && is_array($order_info['payment_custom_field'][$custom_field['custom_field_id']])) {
							foreach ($order_info['payment_custom_field'][$custom_field['custom_field_id']] as $custom_field_value_id) {
								$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($custom_field_value_id);

								if ($custom_field_value_info) {
									$payment_custom_fields[] = array(
										'name'  => $custom_field['name'],
										'value' => $custom_field_value_info['name'],
										'sort_order' => $custom_field['sort_order']
									);
								}
							}
						}

						if ($custom_field['type'] == 'text' || $custom_field['type'] == 'textarea' || $custom_field['type'] == 'file' || $custom_field['type'] == 'date' || $custom_field['type'] == 'datetime' || $custom_field['type'] == 'time') {
							$payment_custom_fields[] = array(
								'name'  => $custom_field['name'],
								'value' => $order_info['payment_custom_field'][$custom_field['custom_field_id']],
								'sort_order' => $custom_field['sort_order']
							);
						}

						if ($custom_field['type'] == 'file') {
							$upload_info = $this->model_tool_upload->getUploadByCode($order_info['payment_custom_field'][$custom_field['custom_field_id']]);

							if ($upload_info) {
								$payment_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $upload_info['name'],
									'sort_order' => $custom_field['sort_order']
								);
							}
						}
					}
				}

				// Shipping
				$shipping_custom_fields = array();

				foreach ($custom_fields as $custom_field) {
					if ($custom_field['location'] == 'address' && isset($order_info['shipping_custom_field'][$custom_field['custom_field_id']])) {
						if ($custom_field['type'] == 'select' || $custom_field['type'] == 'radio') {
							$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($order_info['shipping_custom_field'][$custom_field['custom_field_id']]);

							if ($custom_field_value_info) {
								$shipping_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $custom_field_value_info['name'],
									'sort_order' => $custom_field['sort_order']
								);
							}
						}

						if ($custom_field['type'] == 'checkbox' && is_array($order_info['shipping_custom_field'][$custom_field['custom_field_id']])) {
							foreach ($order_info['shipping_custom_field'][$custom_field['custom_field_id']] as $custom_field_value_id) {
								$custom_field_value_info = $this->model_customer_custom_field->getCustomFieldValue($custom_field_value_id);

								if ($custom_field_value_info) {
									$shipping_custom_fields[] = array(
										'name'  => $custom_field['name'],
										'value' => $custom_field_value_info['name'],
										'sort_order' => $custom_field['sort_order']
									);
								}
							}
						}

						if ($custom_field['type'] == 'text' || $custom_field['type'] == 'textarea' || $custom_field['type'] == 'file' || $custom_field['type'] == 'date' || $custom_field['type'] == 'datetime' || $custom_field['type'] == 'time') {
							$shipping_custom_fields[] = array(
								'name'  => $custom_field['name'],
								'value' => $order_info['shipping_custom_field'][$custom_field['custom_field_id']],
								'sort_order' => $custom_field['sort_order']
							);
						}

						if ($custom_field['type'] == 'file') {
							$upload_info = $this->model_tool_upload->getUploadByCode($order_info['shipping_custom_field'][$custom_field['custom_field_id']]);

							if ($upload_info) {
								$shipping_custom_fields[] = array(
									'name'  => $custom_field['name'],
									'value' => $upload_info['name'],
									'sort_order' => $custom_field['sort_order']
								);
							}
						}
					}
				}
Then, below, find:

Code: Select all

'payment_method'   => $order_info['payment_method'],
add below:

Code: Select all

'account_custom_fields'  => $account_custom_fields,
'shipping_custom_fields' => $shipping_custom_fields,
'payment_custom_fields' => $payment_custom_fields,
Then, in admin/view/template/sale/order_invoice.twig file,

find:

Code: Select all

<b>{{ text_email }}</b> {{ order.store_email }}<br />
add below:

Code: Select all

{% if order.account_custom_fields %}
			  <table class="table table-bordered">
				<thead>
				  <tr>
					<td colspan="2">{{ text_account_custom_field }}</td>
				  </tr>
				</thead>
				<tbody>
				  {% for custom_field in order.account_custom_fields %}
					<tr>
					  <td>{{ custom_field.name }}</td>
					  <td>{{ custom_field.value }}</td>
					</tr>
				  {% endfor %}
				</tbody>
			  </table>
			  <br />
			{% endif %}
Then, find:

Code: Select all

<b>{{ text_payment_method }}</b> {{ order.payment_method }}<br />
add below:

Code: Select all

{% if order.payment_custom_fields %}
			  <table class="table table-bordered">
				<thead>
				  <tr>
					<td colspan="2">{{ text_payment_custom_field }}</td>
				  </tr>
				</thead>
				<tbody>
				  {% for custom_field in order.payment_custom_fields %}
					<tr>
					  <td>{{ custom_field.name }}</td>
					  <td>{{ custom_field.value }}</td>
					</tr>
				  {% endfor %}
				</tbody>
			  </table>
			  <br />
			{% endif %}
Then, find:

Code: Select all

<b>{{ text_shipping_method }}</b> {{ order.shipping_method }}
add below:

Code: Select all

{% if order.shipping_custom_fields %}
			  <table class="table table-bordered">
				<thead>
				  <tr>
					<td colspan="2">{{ text_shipping_custom_field }}</td>
				  </tr>
				</thead>
				<tbody>
				  {% for custom_field in order.shipping_custom_fields %}
					<tr>
					  <td>{{ custom_field.name }}</td>
					  <td>{{ custom_field.value }}</td>
					</tr>
				  {% endfor %}
				</tbody>
			  </table>
			{% endif %}
Then, follow this FAQ: viewtopic.php?f=134&t=215776#p718325

You can re-arrange the invoice presentation as you see fit.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 19 guests