We tested an order and we're getting + and %2C where spaces should exist. I know this is an encoding issue, but it's only on the PayPal side of things and it never appears on OC.
I'm getting a ticket raised with PayPal, but has anyone else experienced the same thing. We're using payment module PayPal Pro iFrame.
Cheers
I'm getting a ticket raised with PayPal, but has anyone else experienced the same thing. We're using payment module PayPal Pro iFrame.
Cheers
PayPal Pro iFrame is no longer supported from the core. I would suggest to use an extension from the Marketplace to stay up-to-date or to use this recent extension: https://www.opencart.com/index.php?rout ... n_id=38358 .
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Quick question... Is this causing an issue? Also %2C equals a comma.andywoodrow wrote: ↑Wed Jun 10, 2020 4:14 pmWe tested an order and we're getting + and %2C where spaces should exist. I know this is an encoding issue, but it's only on the PayPal side of things and it never appears on OC.
I'm getting a ticket raised with PayPal, but has anyone else experienced the same thing. We're using payment module PayPal Pro iFrame.
Cheers
Also a bit more info is needed... What version of OpenCart? Where do you see that %2C exactly?
Mike
cue4cheap not cheap quality
I just don't get this comment. It was in the core in 2.x so why can't they ask questions about it and try to get support for it?straightlight wrote: ↑Wed Jun 10, 2020 5:43 pmPayPal Pro iFrame is no longer supported from the core. I would suggest to use an extension from the Marketplace to stay up-to-date or to use this recent extension: https://www.opencart.com/index.php?rout ... n_id=38358 .
Plus I fear this is going to become what is going to happen in the future with 3.0.3.4 and above when all the modules that makes a cart function (shipping and payment modules) are removed from the core... "That isn't part of the core anymore" THEN "That is an extension ask the maker of the extension". Leaving the small business owners in limbo and sending people AWAY from OC because no one is willing to help anymore.
Mike
cue4cheap not cheap quality
This has already announced and covered. Please see this topic: viewtopic.php?f=2&t=217596 .Cue4cheap wrote: ↑Wed Jun 10, 2020 8:29 pmI just don't get this comment. It was in the core in 2.x so why can't they ask questions about it and try to get support for it?straightlight wrote: ↑Wed Jun 10, 2020 5:43 pmPayPal Pro iFrame is no longer supported from the core. I would suggest to use an extension from the Marketplace to stay up-to-date or to use this recent extension: https://www.opencart.com/index.php?rout ... n_id=38358 .
Plus I fear this is going to become what is going to happen in the future with 3.0.3.4 and above when all the modules that makes a cart function (shipping and payment modules) are removed from the core... "That isn't part of the core anymore" THEN "That is an extension ask the maker of the extension". Leaving the small business owners in limbo and sending people AWAY from OC because no one is willing to help anymore.
Mike
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Sorry but I am still going to help people that ask if it is within my skill set. Aka "Community forum".straightlight wrote: ↑Wed Jun 10, 2020 8:37 pmThis has already announced and covered. Please see this topic: viewtopic.php?f=2&t=217596 .
I think we should still help each other instead of making it about paid support.
Mike
cue4cheap not cheap quality
PayPal Commerce Platform is free and we're still helping each other as it is currently supported for all the users eligible by PayPal, regionally speaking, that are able to use the extension.Cue4cheap wrote: ↑Wed Jun 10, 2020 9:25 pmSorry but I am still going to help people that ask if it is within my skill set. Aka "Community forum".straightlight wrote: ↑Wed Jun 10, 2020 8:37 pmThis has already announced and covered. Please see this topic: viewtopic.php?f=2&t=217596 .
I think we should still help each other instead of making it about paid support.
Mike
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Looking at the code it could be the case that the data send to PayPal is double encoded.
First urlencode is used on each item of the address.
https://github.com/opencart/opencart/bl ... #L219-L250
Then http_build_query is use to build the string.
https://github.com/opencart/opencart/bl ... e.php#L286
http_build_query will generates a URL-encoded query string, which will lead the data to be double encoded, so maybe the the use of urlencode isn't needed. Would need testing in the PayPal sandbox to see if this is the case.
First urlencode is used on each item of the address.
https://github.com/opencart/opencart/bl ... #L219-L250
Then http_build_query is use to build the string.
https://github.com/opencart/opencart/bl ... e.php#L286
http_build_query will generates a URL-encoded query string, which will lead the data to be double encoded, so maybe the the use of urlencode isn't needed. Would need testing in the PayPal sandbox to see if this is the case.
Who is online
Users browsing this forum: No registered users and 16 guests