Post by straightlight » Sat May 30, 2020 11:40 pm

Greetings,

This topic is about how to report bug-fixes for this release. Users who will be testing this release are being amended to report all issues on the Opencart Github > issues tab: https://github.com/opencart/opencart/issues .

Official topic to see test the package: viewtopic.php?f=2&p=788947#p788947 .

Followed is the massive change log, I suppose, everybody was expecting to have after many years:

Code: Select all

[June 25, 2020 - 6:52pm - (EST Time) - Core - Update]: Fixed Catalog Theme parameters.

Code: Select all

Change log:

admin:

- admin language common column left: admin/language/en-gb/common/column_left.php - removed older 3rd party extension language definitions.
- admin startup controller: admin/controller/startup/startup.php - removed openbay.
- admin startup permission controller: admin/controller/startup/permission.php - removed openbay, advertise from google hangouts and google shopping.
- admin common filemanager controller: admin/controller/common/filemanager.php - replaced entire file and ensured no language key from master branch were involved on this release.
- admin language mail voucher: admin/language/en-gb/sale/voucher.php - removed text_sent array key.

catalog:

- catalog startup controller: catalog/controller/startup/startup.php - removed openbay.

install:

- install step_2 controller: install/controller/install/step_2.php - removed older DB libraries from the $db array.
- install cli installer: install/cli_install.php - switched PHP version from 5.4 to 7.1.
- install step_4 language: install/language/en-gb/install/step_4.php - removed older 3rd party extension language definitions.
 
system:

- system config catalog: system/config/catalog.php - removed openbay from library_autoload.

vendor:

- Array of older features: system/storage/vendor/composer/autoload_static.php
- Array of older features: system/storage/vendor/composer/autoload_namespaces.php

---

FIX:

Admin:

- language cache: admin/model/localisation/language.php - fixed cache conventional names causing an increase in the error logs and added SEO URL deletion in deleteLanguage() method.
- admin sale order controller: admin/controller/sale/order.php - fixed option weight from string to decimal value of 0.00 and fixed the api_token and api_key validations. Replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found'). Also fixed the $product_option_value_info validation.
	- fixed convention of getOrderVouchers to read: getVouchers.
	
- admin sale recurring controller: admin/controller/sale/recurring.php - - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin sale order TWIG order info: admin/view/template/sale/order_info.twig - renamed 'token' to array key name: 'api_token' and removed all Openbay instances and JS functions.
- admin marketplace extension detection drop-down menu controller: admin/controller/marketplace/extension.php - fixed the heading_title(0) count issue.
- admin design layout controller: admin/controller/design/layout.php file - added $part[0] as switch case in the $this->load->language call.
- admin model tool image: admin/model/tool/image.php - removed 'image/' and replaced with generic detection based on the DIR_IMAGE constant entered by the store owner.
- admin model tool upload: admin/model/tool/upload.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin common security TWIG file: admin/view/template/common/security.twig - renamed {{text_security }} to {{ text_security }}
- admin event statistics controller: admin/controller/event/statistics.php - renamed all commented out text as per the master branch.
- admin marketing contact controller: admin/controller/marketing/contact.php - added new $email_total arrays as per the master branch.
- admin language mail voucher: admin/language/en-gb/mail/voucher.php - moved text_sent key to this language definition.
- admin design layout form TWIG file: admin/view/template/design/layout/translation_form.twig - replaced JS functions with the ones from the master branch by keeping the same CSS elements.
- admin design layout list TWIG file: admin/view/template/design/layout/translation_list.twig - replaced JS functions with the ones from the master branch by keeping the same CSS elements.
- admin extension payment free checkout TWIG file: admin/view/template/extension/payment/free_checkout.twig - fixed free_checkout to read: payment_free_checkout.
- admin extension payment free checkout controller: admin/controller/extension/payment/free_checkout.php - fixed free_checkout to read: payment_free_checkout.
- admin marketing coupon controller: admin/controller/marketing/coupon.php - fixed various codes.
- admin language sale order controller: admin/language/en-gb/sale/order.php - fixed order ID # string originating from sprintf.
- admin extension report product viewed controller: admin/controller/extension/report/product_viewed.php - fixed $data['reset'] URL string.
- admin extension dashboard chart controller: admin/controller/extension/dashboard/chart.php - fixed dashboard_chart_width array key.
- admin common dashboard TWIG file: admin/view/template/common/dashboard.twig - fixed button_developer ID and link.
- admin customer controller: admin/controller/customer/customer.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin marketplace controller: admin/controller/marketplace/marketplace.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- admin model user: admin/model/user/user.php - STILL REQUIRES FIXING ON GITHUB - CAUSING MYSQLi FETCH ARRAY TO APPEAR IN THE ADMIN!
- admin model customer: admin/model/customer/customer.php - CAUSING MYSQLi FETCH ARRAY TO APPEAR IN THE ADMIN!
- admin report online TWIG file: admin/view/template/report/online.twig - fixed IP address lookup URL with http://www.geoiptool.com/en/?IP= .
- admin customer customer_ip TWIG file: admin/view/template/customer/customer_ip.twig - fixed IP address lookup URL with http://www.geoiptool.com/en/?IP= .
- admin common column_left controller: admin/controller/common/column_left.php - fixed model reports with floats as per the master branch.
- admin localisation location list TWIG file: admin/view/template/localisation/location_list.twig - fixed locations to location in the for loop.
- admin localisation location controller: admin/controller/localisation/location.php - fixed location to locations in the $data and the foreach loop.
- admin customer controller: admin/controller/customer/customer.php - fixed various issues.
	- Fixed validation for localisation and value IDs as per the master branch.

- admin customer custom fields controller: admin/controller/customer/custom_field - fixed customer groups validation fields as per the master branch.
- admin mail customer controller: admin/controller/mail/customer.php - Fixed $data['login'] to affect $store_url as the URL in the approve() method.
- admin product form TWIG file: admin/view/template/catalog/product_form.twig - fixed select ending double tags with single tags.
	- Fixed JS lookups as per the master branch.
	
- admin affiliate mail approve language: admin/language/en-gb/mail/affiliate_approve.php - fixed text_services to read: text_service.
- admin sale return controller: admin/controller/sale/return.php - fixed sort_status URL from sort=status to sort=return_status.
- admin model sale return: admin/model/sale/return.php - fixed sort_status filter from sort=status to sort=return_status.
- admin common dashboard security controller: admin/controller/common/dashboard.php - fixed common/developer for common/security in permission validation.
- admin model catalog product: admin/model/catalog/product.php - fixed conventional names.
- admin model catalog filter: admin/model/catalog/filter.php - fixed duplicated getDescriptions method and changed the filter group model to getGroupDescriptions as per the master branch.
- admin catalog filter controller: admin/controller/catalog/filter.php - fixed filter group model call to read getGroupDescriptions.
- admin marketing coupon controller: admin/controller/marketing/coupon.php - fixed getCouponHistories to read getHistories.
- admin mail controller: admin/controller/mail/affiliate*, admin/controller/mail/customer* - fixed missing $data variables and added logo for HTML emails.
- admin mail language: admin/controller/mail/affiliate*, admin/controller/mail/customer* - fixed missing language definitions.
- admin view mail template: admin/view/template/mail/affiliate*, admin/controller/mail/customer* - replaced text templates with HTML templates.
- admin customer controller: admin/controller/customer/customer.php - fixed affiliate tracking validation.
- admin model seo_url: admin/model/design/seo_url - fixed sort by query key.
- admin localisation country en-gb language: admin/language/en-gb/localisation/country.php - removed error_affiliate entry.
- admin localisation zone en-gb language: admin/language/en-gb/localisation/zone.php - removed error_affiliate entry.
- admin sale recurring controller: admin/controller/sale/recurring.php - fixed sort recurring_id string for or.order_recurring_id.
- admin catalog attribute groups controller: admin/controller/catalog/attribute_group.php - fixed conventional name to use the new name of: getGroupDescriptions.

Catalog:

- catalog mail order controller page: catalog/controller/mail/order.php - Added $this->load->model('checkout/order'); in index(...) and alert(...)
- catalog model tool image: catalog/model/tool/image.php - removed 'image/' and replaced with generic detection based on the DIR_IMAGE constant entered by the store owner.
- catalog model total voucher extension order complete statuses - catalog/model/extension/total/voucher.php - switched from IN to OR in the SQL statement. Added false status if no imploded order complete statuses can also be found.
- catalog login controller validation page: catalog/controller/account/login.php - added email validation in the validate method.
- catalog login language: catalog/language/en-gb/account/login.php - added error_email definition.
- catalog model checkout recurring: catalog/model/checkout/recurring.php - fixed addRecurring INSERT SQL statement with the $data recurring keys.
- catalog checkout controller: catalog/controller/checkout/checkout.php - removed older 3rd party extension payment lookups.
- catalog event statistics controller: catalog/controller/event/statistics.php - replaced all commented out text as per the master branch.
- catalog event debug controller: catalog/controller/event/debug.php - replaced the debug controller with the master branch version.
- catalog event activity controller: catalog/controller/event/activity.php - fixed addOrderHistory method by referring to master branch and fixed commented out text information.
- catalog view checkout guest TWIG file: catalog/view/theme/default/template/checkout/guest.twig - fixed custom fields placeholder element.
- catalog account order controller: catalog/controller/account/order.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- catalog account tracking controller: catalog/controller/account/tracking.php - replaced error/not_found or return new Action('error/not_found') codes with: $this->load->controller('error/not_found')
- catalog account login controller: catalog/controller/account/login.php - fixed login and redirection validations.
- catalog affiliate login controller: catalog/controller/affiliate/login.php - fixed login and redirection validations.
- catalog pp braintree extension payment TWIG file: catalog/view/theme/default/template/extension/payment/pp_braintree.twig - replaced with id="discover-logo".
- catalog model extension shipping weight: catalog/model/extension/shipping/weight.php - moved $this->cart->getWeight() before loop.
- catalog model setting extension: catalog/model/setting/extension.php - fixed function with public function call.
- catalog model extension total sub-total: catalog/model/extension/total/sub_total.php - fixed $this->config->get total_ prefix.
- catalog mail controller: catalog/controller/mail/affiliate*, catalog/controller/mail/customer* - fixed missing $data variables and added logo for HTML emails.
- catalog mail language: catalog/controller/mail/affiliate*, catalog/controller/mail/customer* - fixed missing language definitions.
- catalog view mail template: catalog/view/template/mail/affiliate*, catalog/controller/mail/customer* - replaced text templates with HTML templates.

System:

- system library mail SMTP: system/library/mail/smtp.php - replaced it with the master branch' version.
- system library cache: system/library/cache/file.php - replaced file with master branch' version.
- system startup: system/startup.php - fixed DIR_STORAGE constant to see if it has been defined prior to its installation.
- system library document: system/library/document.php - fixed document variable names. 
- system library session: system/library/session.php - fixed __destruct() back to: __destroy().
- system library db mysqli: system/library/db/mysqli.php - added validation to close connection with mysqli due to mysqli fetch error.
 
Install:

- install model upgrade 1009: install/model/upgrade/1009.php - fixed currency, country, event, image, zone, setting, zone to geo zone database tables.
	- Added varchar(60) to company fields as per the master branch.
	- Added more event queries to switch from addOrderHistory to addHistory as per the master branch.
	- Switched from config_limit_admin to config_pagination config key as per the master branch.
	
-- Addition --

Admin:

- admin startup router controller: admin/controller/startup/router.php: added string type to the route as per the master branch.
- admin language en-gb: admin/language/en-gb/en-gb.php - added button_developer
- admin systems store controller: admin/controller/setting/store.php - added store_total counter and incremented getTotalStores method as per the master branch.

Catalog:

- catalog information contact controller page: catalog/controller/information/contact.php - added $data['text_message'] due to a blank page on the contact success page.
- catalog account translation controller: catalog/controller/account/translation.php - added text_empty language definition.
- catalog product special controller: catalog/controller/product/special.php - added text_empty language definition.
- catalog product category controller: catalog/controller/product/category.php - added text_empty language definition.
- catalog product search controller: catalog/controller/product/search.php - added text_empty language definition.
- catalog product manufacturer controller: catalog/controller/product/manufacturer.php - added text_empty language definition.
- catalog startup router controller: catalog/controller/startup/router.php - added string type to the route as per the master branch.
- catalog model checkout order controller: catalog/model/checkout/order.php - added getOrderRecurring method.
- catalog account recurring controller: catalog/controller/account/recurring.php - added $this->response->addHeader with 404 error.
- catalog account return controller: catalog/controller/account/return.php  - added $this->response->addHeader with 404 error.
- catalog checkout cart controller: catalog/controller/checkout/cart.php - added $this->response->addHeader with 404 error.

-- DATABASE FIXES --

- oc_setting
- oc_event
	- 'statistics_order_history', 'catalog/model/checkout/order/addOrderHistory/before', 'event/statistics/addOrderHistory'
	- 'mail_affiliate_add', 'catalog/model/account/customer/addAffiliate/after', 'mail/affiliate'
	- 'mail_affiliate_alert', 'catalog/model/account/customer/addAffiliate/after', 'mail/affiliate/alert'
	- 'admin_mail_return', 'admin/model/sale/return/addReturnHistory/after', 'mail/return'
	
- oc_image
- oc_language
- oc_country
- oc_zone
- oc_zone_to_geo_zone
- oc_user_group - keep the JSON permission strings up-to-date.
- Added escaped '`' containing: name, code and key fields from the models.

-- Page integers --

- All $page = $this->request->get['page']; from all controllers have now been changed to: $page = (int)$this->request->get['page'];

-- install.txt file --

- The install.txt file has been updated with more recent installation steps.

-- upgrade.txt file --

- The upgrade.txt file > troubleshooting now includes step 4.

-- .user.ini file --

Due to the latest compliancy of cPanel (Web Hosting Control Panel), the .user.ini file may be required for most web servers, depending on which cPanel version you may have.
This file has now been included on the package as a duplication file of the php.ini's original file from this package.

-- admin languages and themes for extension/report --

Replaced duplicated text_status with text_order_status or text_recurring_status depending on the situation.

-- catalog double $information_info['title'] --

- catalog/controller/account/register.php
- catalog/controller/account/return.php
- catalog/controller/affiliate/register.php
- catalog/controller/checkout/payment_method.php
- catalog/controller/checkout/register.php

Now using single $information_info['title'] with sprintf.

-- frequencies array move out away from the loops --

- catalog/controller/extension/module/paypal_smart_button.php
- catalog/controller/checkout/confirm.php
- catalog/controller/checkout/cart.php

-- Switching time to datetime where: 'data-date-format="YYYY-MM-DD HH:mm"' are involved --

- catalog/view/theme/default/template/checkout/shipping_address.twig
- catalog/view/theme/default/template/checkout/payment_address.twig
- catalog/view/theme/default/template/checkout/register.twig
- catalog/view/theme/default/template/checkout/guest_shipping.twig
- catalog/view/theme/default/template/checkout/guest.twig
- catalog/view/theme/default/template/checkout/register.twig
- catalog/view/theme/default/template/affiliate/register.twig
- catalog/view/theme/default/template/account/register.twig
- catalog/view/theme/default/template/account/edit.twig
- catalog/view/theme/default/template/account/affiliate.twig
- catalog/view/theme/default/template/account/address_form.twig

-- Affliate terms to: Affiliate --

- Fixed all terms to appropriate terms.

-- Conventional method names --

- Changed all conventional method names from the controllers and models as per the master branch.

-- Pagination controller --

- All new Pagination() class have now been renamed with the new controller convention of: $this->load->controller('common/pagination', array(...)) as per the master branch.
- Removed system/library/pagination.php file (should be removed from the master branch).
- Added admin/controller/common/pagination.php file as per the master branch.
- Added admin/view/template/common/pagination.twig file as per the master branch.
- Added catalog/controller/common/pagination.php file as per the master branch.
- Added catalog/view/template/common/pagination.twig file as per the master branch.

-- Product thumb --

- $this->load->controller('product/thumb', array(...)) has been added as per the master branch.
- Removed old language definitions.
- Merged <div ... by using {{ product }} as per the commit changes.
However, this topic will be unlocked in case additional information based on these core file and database changes might need to be addressed by forum users.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sun May 31, 2020 1:16 am

Looks like you lot have been busy getting this release ready however....
In the admin/extensions/modules there seems to be a problem with the last module i.e "heading_title yet when you install it and click edit it comes up with this error

Code: Select all

Fatal error: Uncaught Twig_Error_Loader: Unable to find template "extension/module/pp_braintree_button.twig" (looked into: C:/xampp/htdocs/oc3.0.3.4/admin/view/template). in C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php:215 Stack trace: #0 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php(139): Twig_Loader_Filesystem->findTemplate('extension/modul...') #1 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Environment.php(312): Twig_Loader_Filesystem->getCacheKey('extension/modul...') #2 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Environment.php(378): Twig_Environment->getTemplateClass('extension/modul...', NULL) #3 C:\xampp\htdocs\oc3.0.3.4\system\library\template\twig.php(33): Twig_Environment->loadTemplate('extension/modul...') #4 C:\xampp\htdocs\oc3.0.3.4\system\library\template.php(51): Template\Twig->render('extension/modul...', '1') #5 C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php(125): Template->render('extension/modul...', '1') #6 C:\xa in C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php on line 215

Attachments

3034modules.JPG

3034modules.JPG (56.7 KiB) Viewed 24631 times


Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sun May 31, 2020 1:27 am

cyclops12 wrote:
Sun May 31, 2020 1:16 am
Looks like you lot have been busy getting this release ready however....
In the admin/extensions/modules there seems to be a problem with the last module i.e "heading_title yet when you install it and click edit it comes up with this error

Code: Select all

Fatal error: Uncaught Twig_Error_Loader: Unable to find template "extension/module/pp_braintree_button.twig" (looked into: C:/xampp/htdocs/oc3.0.3.4/admin/view/template). in C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php:215 Stack trace: #0 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php(139): Twig_Loader_Filesystem->findTemplate('extension/modul...') #1 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Environment.php(312): Twig_Loader_Filesystem->getCacheKey('extension/modul...') #2 C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Environment.php(378): Twig_Environment->getTemplateClass('extension/modul...', NULL) #3 C:\xampp\htdocs\oc3.0.3.4\system\library\template\twig.php(33): Twig_Environment->loadTemplate('extension/modul...') #4 C:\xampp\htdocs\oc3.0.3.4\system\library\template.php(51): Template\Twig->render('extension/modul...', '1') #5 C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php(125): Template->render('extension/modul...', '1') #6 C:\xa in C:\xampp\htdocs\oc3.0.3.4\system\library\template\Twig\Loader\Filesystem.php on line 215
Ok, fixed. Both packages have been re-uploaded. Thanks for posting this.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 1:51 am

Ok, it's been re-uploaded again. All braintree files should be in the package now.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 2:11 am

Another shit and fast release...when Daniel is too lazy to merge some pull requests....

Category bug is still there...
https://github.com/opencart/opencart/co ... dfa023bd92

Code: Select all

 <td class="text-left">{% if sort %}
...

And 100% are more ...

My pull request
https://github.com/opencart/opencart/pull/7963/files

Same this bug:

Code: Select all

if ($product_option_value_info) {
Last edited by xxvirusxx on Sun May 31, 2020 3:17 am, edited 1 time in total.

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 2:17 am

xxvirusxx wrote:
Sun May 31, 2020 2:11 am
Another shit and fast release...when Daniel is too lazy to merge some pull requests....

Category bug is still there...

Code: Select all

 <td class="text-left">{% if sort %}
...

And 100% are more ...

My pull request
https://github.com/opencart/opencart/pull/7963/files

Same this bug:

Code: Select all

if ($product_option_value_info) {
Based on the change logs size provided on the first post, see, I am not really sure what you mean. As for the two bugs you've addressed specifically, I just added them on the list.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 2:21 am

I mean he ignore when users like me...keep try to help...but are ignored...

This still not fixed from 3.0.2.0
sub_total file: controller, twig from admin

Code: Select all

		if (isset($this->request->post['sub_total_sort_order'])) {
			$data['sub_total_sort_order'] = $this->request->post['sub_total_sort_order'];
		} else {
			$data['sub_total_sort_order'] = $this->config->get('sub_total_sort_order');
		}
This was not changed from:
catalog/controller/information/contact.php

Code: Select all

$mail->setFrom($this->config->get('config_email'));
to:

Code: Select all

$mail->setFrom($this->request->post['email']);
This:
/admin/view/template/mail/affiliate_approve.twig

Code: Select all

{{ text_service }}
to this:

Code: Select all

{{ text_services }}
This:
admin/controller/sale/order.php

Code: Select all

{% if option %}
to this:

Code: Select all

{% if product.option %}
This:

Code: Select all

$sql .= " AND CONCAT(firstname, ' ', o.lastname) LIKE '%" . $this->db->escape($data['filter_customer']) . "%'";
to this:

Code: Select all

$sql .= " AND CONCAT(firstname, ' ', lastname) LIKE '%" . $this->db->escape($data['filter_customer']) . "%'";
Do you want to continue?

This:
admin/view/template/sale/order_form.twig

Code: Select all

html += '<option value="" style="color: #F00;" disabled="disabled">' + json['shipping_method'][i]['error'] + '</option>';
to this:

Code: Select all

html += '<option value="" style="color: #F00;" disabled="disabled">' + json['shipping_methods'][i]['error'] + '</option>';
This:
admin/model/localisation/language.php

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "seo_url WHERE language_id = '" . (int)$language_id . "'");
After this

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "language WHERE language_id = '" . (int)$language_id . "'");
https://github.com/opencart/opencart/issues/6830
Same duplicate code....

Code: Select all

{% if custom_field.type == 'time' %}
Etc...

You remember this?
viewtopic.php?f=201&t=201856&p=712927

Code: Select all

<div class="table-responsive">
Still not added...
Last edited by xxvirusxx on Sun May 31, 2020 3:27 am, edited 8 times in total.

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 2:44 am

xxvirusxx wrote:
Sun May 31, 2020 2:21 am
I mean he ignore when users like me...keep try to help...but are ignored...

This still not fixed from 3.0.2.0

Code: Select all

		if (isset($this->request->post['sub_total_sort_order'])) {
			$data['sub_total_sort_order'] = $this->request->post['sub_total_sort_order'];
		} else {
			$data['sub_total_sort_order'] = $this->config->get('sub_total_sort_order');
		}
This was not changed from:

Code: Select all

$mail->setFrom($this->config->get('config_email'));
to:

Code: Select all

$mail->setFrom($this->request->post['email']);
This:

Code: Select all

{{ text_service }}
to this:

Code: Select all

{{ text_services }}
This:

Code: Select all

{% if option %}
to this:

Code: Select all

{% if product.option %}
This:

Code: Select all

$sql .= " AND CONCAT(firstname, ' ', o.lastname) LIKE '%" . $this->db->escape($data['filter_customer']) . "%'";
to this:

Code: Select all

$sql .= " AND CONCAT(firstname, ' ', lastname) LIKE '%" . $this->db->escape($data['filter_customer']) . "%'";
Do you want to continue?

This:

Code: Select all

html += '<option value="" style="color: #F00;" disabled="disabled">' + json['shipping_method'][i]['error'] + '</option>';
to this:

Code: Select all

html += '<option value="" style="color: #F00;" disabled="disabled">' + json['shipping_methods'][i]['error'] + '</option>';
This:

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "seo_url WHERE language_id = '" . (int)$language_id . "'");
After this

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "language WHERE language_id = '" . (int)$language_id . "'");
Same duplicate code....

Code: Select all

{% if custom_field.type == 'time' %}
Etc...

You remember this?

Code: Select all

<div class="table-responsive">
Still not added...
Then, let me make it clear for you. While I do appreciate the fact you are providing further bug-fixes, Daniel didn't worked on this pre-release version since the past 2.5 days - while this distribution was his idea, I did worked on this release as well as mentioned on my first post that I would open this topic for users who would need to report further bug-fixes solutions in case there would be missing ones. If there's something you're unleashing about right now is the fact that I took initiative to help the most forum and Github users as possible to consider their past solutions in order to build the most flexible release as we speak.

As a personal note, you should rather be grateful that someone like me stands around the forum and on Github to take initiative as to ensure the demands are met by the users. The only reason why things didn't go that smooth and fast in the past is because Daniel was busy working on other projects as I wasn't assigned on this one particularly. In addition, the fact that we all have lives, people still needs to dedicate their time to work on this platform to get what they need. If it weren't for my regular job, I'd implement all these solutions in a day. But instead, it took me 2.5 days since I was assigned to implement the mass solution as opposed to what you are complaining about on the above.

From this point forward, you don't like the ways the packages are being distributed, especially due to the mount of work that was required to fix most of the major incidents, at this point - I would provide my inputs to you that you are more than welcome to leave.

To set the record straight, Daniel may not talk a lot nowadays on the forum, but I do, and if there are people who still don't appreciate the time and effort that was put into this release, as slow as it used to evolved with previous releases, then you'd be one more on the welcoming to stay behind with the releases while Opencart will keep going forward.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 2:54 am

So to add, your last post regarding the steps you provided are incomplete. As the forum rules dictates, detailed information must be provided. Based on what you have addressed with the codes, no files are being associated with your claim. At this point, if you'd really want to help, without bringing the criticism on the table, you'd also address the commit, posts, links and / or files. Those information have not been provided on your behalf. You've been here long enough on the forum. You should know how to provide information to the public forum by now.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 2:56 am

If someone added this bugs fix from 3.0.2.0 to 3.0.3.4, now this version was more stable...until 3.1.x.x was release...
As I said..I can create more pull request...to remember old bugs...and new ones, but there is no one to merge...

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 3:29 am

and new ones, but there is no one to merge...
Despite. While you may have these abilities, the previous post on this topic still doesn't provide the locations where the codes you're addressing about may require reviews. While I may not know the reason exactly what did happened on the commits you are putting on the subject about, there might of been specific reasons why your posts may not have been merged on Github but one that I can find already is the lack of information posted on your behalf as the way you are treating a forum administrator and a founder.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 3:45 am

straightlight wrote:
Sun May 31, 2020 3:29 am
as the way you are treating a forum administrator and a founder.
Ban me, then delete all my info (topics/posts-GDPR)

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 4:01 am

As per the notes addressed in the admin/model/localisation/language.php file:

Code: Select all

/*
		Do not put any delete code for related tables for languages!!!!!!!!!
		
		It is not required as when ever you re save to a multi language table then the entries for the deleted language will also be deleted! 
		
		Wasting my time with people adding code here!
		*/
Your post above suggests to consider the alternate route.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 5:05 am

straightlight wrote:
Sun May 31, 2020 4:01 am
As per the notes addressed in the admin/model/localisation/language.php file:
This line is in Master Branch

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "seo_url WHERE language_id = '" . (int)$language_id . "'");
Missing from 3.0.x.x

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 5:07 am

xxvirusxx wrote:
Sun May 31, 2020 5:05 am
straightlight wrote:
Sun May 31, 2020 4:01 am
As per the notes addressed in the admin/model/localisation/language.php file:
This line is in Master Branch

Code: Select all

$this->db->query("DELETE FROM " . DB_PREFIX . "seo_url WHERE language_id = '" . (int)$language_id . "'");
Missing from 3.0.x.x
This release is not yet based on the master branch as a priority. The priority is to ensure major incidents are, first, being resolved so that people can resume their normal tasks on the platform. Then, to focus on feature issues from the core.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Sun May 31, 2020 5:14 am

I've raised a issue about the PayPal Commerce Platform checkout problem with Japanese yen (and possibly other currencies that don't use 2 decimal places).
https://github.com/opencart/opencart/issues/7972

Caused by attempted fix for rounding issues.
https://github.com/opencart/opencart/is ... -632344760

www.add-creative.co.uk


Active Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Sun May 31, 2020 5:16 am

ADD Creative wrote:
Sun May 31, 2020 5:14 am
I've raised a issue about the PayPal Commerce Platform checkout problem with Japanese yen (and possibly other currencies that don't use 2 decimal places).
https://github.com/opencart/opencart/issues/7972

Caused by attempted fix for rounding issues.
https://github.com/opencart/opencart/is ... -632344760
Ok, thanks for addressing this issue.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 5:47 am

straightlight wrote:
Sun May 31, 2020 5:07 am
This release is not yet based on the master branch as a priority. The priority is to ensure major incidents are, first, being resolved so that people can resume their normal tasks on the platform.
So this bug isn't a priority?
https://github.com/opencart/opencart/issues/6010

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 6:09 am

xxvirusxx wrote:
Sun May 31, 2020 5:47 am
straightlight wrote:
Sun May 31, 2020 5:07 am
This release is not yet based on the master branch as a priority. The priority is to ensure major incidents are, first, being resolved so that people can resume their normal tasks on the platform.
So this bug isn't a priority?
https://github.com/opencart/opencart/issues/6010
Not at this time, it isn't. These posts will still be considered but, as said before, we need to prioritize with major incidents first. As Add Creative has addressed on the above, people do need to complete payment with PayPal and they can't which means it becomes a dead-end point for the customers to complete. This is a more serious example than simple SEO changes. Besides, Daniel has worked on the SEO URLs this week as per his commit changes states.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 6:14 am

Since it was added on the master branch, I have added the query line in the deleteLanguage but the fact that priorities needs to be focused on customers' success remains until we can get to the most bottom of it. The next package change will be ready soon. Will post an update about it since I am still working on several other bug-fixes solutions right now.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 4 guests