Post by ADD Creative » Fri Jul 03, 2020 12:50 am

straightlight wrote:
Sun May 31, 2020 9:28 pm
ADD Creative wrote:
Sun May 31, 2020 9:23 pm
straightlight wrote:
Sun May 31, 2020 8:43 pm
This fix was handled by Jesse on Github: https://github.com/opencart/opencart/bl ... ontact.php . It is using the $this->request->post['email'] . You'll have to address this issue on the Github Opencart issues tab.
I did and also someone else pointed out it was wrong. https://github.com/opencart/opencart/pull/6594

Also here is stated as some hosts will not send email from other addreses https://github.com/opencart/opencart/is ... -239400277

Putting the customer's email address as the from address seems to be a workaround for a bug in some Microsoft email clients that ignore the reply-to address. Hopefully Microsoft will have fixed that by now.
I have addressed this issue to Daniel regarding those two variables especially since the $this->request->post['email'] has already been added on the master branch. Based on his decision, an update will be posted.
You have this wrong and now it is the worst of both worlds. There is now way to reply to the email at all now.
catalog/controller/information/contact.php:

Code: Select all

$mail->setReplyTo($this->config->get('config_email'));
Should be:

Code: Select all

$mail->setReplyTo($this->request->post['email']);

www.add-creative.co.uk


Active Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by jrr » Sat Jul 18, 2020 1:30 pm

Ah, I appear to have broken 3.0.3.4_core - when I am in admin, and try to edit an image or even open the image file I am kicked back to the admin login page.

What I see on the edit page. I did the upgrades from the previous page (15) and it seems to work otherwise...

I assume this is a permissions problem, where would I be best to look for this?

Thanks!

Image

jrr
New member

Posts

Joined
Mon Nov 20, 2017 1:48 pm

Post by straightlight » Sun Jul 19, 2020 12:24 am

Daniel has applied several bug-fixes on the master branch today which also includes the bug-fixes on the pre-core release: https://github.com/opencart/opencart/commits .

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by jrr » Sun Jul 19, 2020 1:06 am

straightlight wrote:
Sun Jul 19, 2020 12:24 am
Daniel has applied several bug-fixes on the master branch today which also includes the bug-fixes on the pre-core release: https://github.com/opencart/opencart/commits .
Thank you Daniel (and straightlight)!
Looks like a new release too - 3.0.3.5 https://github.com/opencart/opencart/re ... ag/3.0.3.5 - guess I'll check that out now...

jrr
New member

Posts

Joined
Mon Nov 20, 2017 1:48 pm

Post by xxvirusxx » Sun Jul 19, 2020 1:27 am

straightlight wrote:
Sun Jul 19, 2020 12:24 am
Daniel has applied several bug-fixes on the master branch today which also includes the bug-fixes on the pre-core release: https://github.com/opencart/opencart/commits .
Or not... :) (3.0.3.5)

Code: Select all

if (isset($this->request->post['sub_total_sort_order'])) {

Code: Select all

$data['dashboard_chart_width'] = $this->config->get('dashboardchart_width');

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun Jul 19, 2020 3:02 am

3.0.3.5 is not the master branch.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by jrr » Sun Jul 19, 2020 1:10 pm

straightlight wrote:
Sun Jul 19, 2020 3:02 am
3.0.3.5 is not the master branch.
Sorry, what does the above mean? Where exactly is the master branch hiding then?
My impression was that you (@straighlight) was recommending using 3.0.3.4_core for those of us interested in the latest version of OC, and yet now you seem to be saying that the version 3.0.3.5, from (apparently) Daniel is not the correct version to follow. Or am I misreading it?

I guess that is the problem with new code versions, one is always on the bloody bleeding edge!

So, @straightlight, if not 3.0.3.5, and possibly not 3.0.3.4_core , what on earth should those of us thinking of switching to OC from another cart (oscMax in my case) be best at looking at for a stable platform for the next year or two while bugs are sorted out?

Thank you!

jrr
New member

Posts

Joined
Mon Nov 20, 2017 1:48 pm

Post by straightlight » Sun Jul 19, 2020 9:07 pm

Covering a previous post. SessionBySessonId conventions have now been changed to: SessionBySessionId in master branch: https://github.com/opencart/opencart/co ... 2f6a95R385 .

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 8 guests