Page 16 of 16
Re: Opencart Pre-Release v3.0.3.4
Posted: Fri Jul 03, 2020 12:50 am
by ADD Creative
straightlight wrote: ↑Sun May 31, 2020 9:28 pm
I have addressed this issue to Daniel regarding those two variables especially since the $this->request->post['email'] has already been added on the master branch. Based on his decision, an update will be posted.
You have this wrong and now it is the worst of both worlds. There is now way to reply to the email at all now.
catalog/controller/information/contact.php:
Code: Select all
$mail->setReplyTo($this->config->get('config_email'));
Should be:
Code: Select all
$mail->setReplyTo($this->request->post['email']);
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sat Jul 18, 2020 1:30 pm
by jrr
Ah, I appear to have broken 3.0.3.4_core - when I am in admin, and try to edit an image or even open the image file I am kicked back to the admin login page.
What I see on the edit page. I did the upgrades from the previous page (15) and it seems to work otherwise...
I assume this is a permissions problem, where would I be best to look for this?
Thanks!
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 12:24 am
by straightlight
Daniel has applied several bug-fixes on the master branch today which also includes the bug-fixes on the pre-core release:
https://github.com/opencart/opencart/commits .
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 1:06 am
by jrr
Thank you Daniel (and straightlight)!
Looks like a new release too - 3.0.3.5
https://github.com/opencart/opencart/re ... ag/3.0.3.5 - guess I'll check that out now...
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 1:27 am
by xxvirusxx
Or not...
(3.0.3.5)
Code: Select all
if (isset($this->request->post['sub_total_sort_order'])) {
Code: Select all
$data['dashboard_chart_width'] = $this->config->get('dashboardchart_width');
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 3:02 am
by straightlight
3.0.3.5 is not the master branch.
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 1:10 pm
by jrr
straightlight wrote: ↑Sun Jul 19, 2020 3:02 am
3.0.3.5 is not the master branch.
Sorry, what does the above mean? Where exactly is the master branch hiding then?
My impression was that you (@straighlight) was recommending using 3.0.3.4_core for those of us interested in the latest version of OC, and yet now you seem to be saying that the version 3.0.3.5, from (apparently) Daniel is not the correct version to follow. Or am I misreading it?
I guess that is the problem with new code versions, one is always on the bloody bleeding edge!
So, @straightlight, if not 3.0.3.5, and possibly not 3.0.3.4_core , what on earth should those of us thinking of switching to OC from another cart (oscMax in my case) be best at looking at for a stable platform for the next year or two while bugs are sorted out?
Thank you!
Re: [SOLVED] - Opencart Pre-Release - Core v3.0.3.4
Posted: Sun Jul 19, 2020 9:07 pm
by straightlight
Covering a previous post. SessionBySessonId conventions have now been changed to: SessionBySessionId in master branch:
https://github.com/opencart/opencart/co ... 2f6a95R385 .