Post by WayneSallee » Thu Jun 04, 2020 12:57 am

admin/view/javascript/bootstrap/js/ bootstrap.js is version 3.3.1 and bootstrap.min.js is version 3.3.5

It looks like copying catalog/view/javascript/bootstrap/js/bootstrap.js
over
admin/view/javascript/bootstrap/js/bootstrap.js
will correct this.

Wayne Sallee
Wayne@WayneSallee.com

Newbie

Posts

Joined
Sat Jul 13, 2019 11:31 pm
Location - Leesburg, Florida, USA

Post by straightlight » Thu Jun 04, 2020 1:07 am

For more recent Bootstrap versions, please address these issues on Github Opencart bt using the Bug Tracker link from the Resources link at the top of the site.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by WayneSallee » Thu Jun 04, 2020 2:45 am

straightlight wrote:
Thu Jun 04, 2020 1:07 am
For more recent Bootstrap versions, please address these issues on Github Opencart bt using the Bug Tracker link from the Resources link at the top of the site.
I'm not sure what you are trying to say. Isn't bootstrap.js supposed to be a nonminified version of bootstrap.min.js ?

Wayne Sallee
Wayne@WayneSallee.com

Newbie

Posts

Joined
Sat Jul 13, 2019 11:31 pm
Location - Leesburg, Florida, USA

Post by straightlight » Thu Jun 04, 2020 3:09 am

WayneSallee wrote:
Thu Jun 04, 2020 2:45 am
straightlight wrote:
Thu Jun 04, 2020 1:07 am
For more recent Bootstrap versions, please address these issues on Github Opencart bt using the Bug Tracker link from the Resources link at the top of the site.
I'm not sure what you are trying to say. Isn't bootstrap.js supposed to be a nonminified version of bootstrap.min.js ?

Wayne Sallee
Wayne@WayneSallee.com
Yes but the version you are addressing is not yet officially supported on opencart.com .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by WayneSallee » Fri Jun 05, 2020 1:20 am

straightlight wrote:
Thu Jun 04, 2020 3:09 am
Yes but the version you are addressing is not yet officially supported on opencart.com .
Maybe you don't understand what I am saying.
Look at the first few lines in the following files:


admin/view/javascript/bootstrap/js/bootstrap.js

Code: Select all

/*!
 * Bootstrap v3.3.1 (http://getbootstrap.com)
 * Copyright 2011-2014 Twitter, Inc.
 * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
 */
admin/view/javascript/bootstrap/js/bootstrap.min.js

Code: Select all

/*!
 * Bootstrap v3.3.5 (http://getbootstrap.com)
 * Copyright 2011-2015 Twitter, Inc.
 * Licensed under the MIT license
 */
Wayne Sallee
Wayne@WayneSallee.com

Newbie

Posts

Joined
Sat Jul 13, 2019 11:31 pm
Location - Leesburg, Florida, USA

Post by straightlight » Fri Jun 05, 2020 1:51 am

OC version?

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by WayneSallee » Fri Jun 05, 2020 9:53 pm

straightlight wrote:
Fri Jun 05, 2020 1:51 am
OC version?
3.03.3
3.03.2
And posibly other versions.

Wayne Sallee
Wayne@WayneSallee.com

Newbie

Posts

Joined
Sat Jul 13, 2019 11:31 pm
Location - Leesburg, Florida, USA

Post by straightlight » Fri Jun 05, 2020 9:56 pm

Can't reproduce the issue with the pre-release. Only v3.3.5 for bootstrap is showing.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by WayneSallee » Fri Jun 05, 2020 10:59 pm

straightlight wrote:
Fri Jun 05, 2020 9:56 pm
Can't reproduce the issue with the pre-release. Only v3.3.5 for bootstrap is showing.

I see that you now have a 3.0.3.4 pre-release.
It is *not* fixed in the 3.0.3.4 pre-release.
Maybe you have a pre-release for 3.03.4 that is newer than the downloadable pre-release, where it has been fixed?

I do see though, that it has been upgraded on github and therefore fixed. So when the current master becomes a release it will be fixed then.

Wayne Sallee
Wayne@WayneSallee.com

Newbie

Posts

Joined
Sat Jul 13, 2019 11:31 pm
Location - Leesburg, Florida, USA

Post by straightlight » Fri Jun 05, 2020 11:10 pm

Maybe you have a pre-release for 3.03.4 that is newer than the downloadable pre-release, where it has been fixed?
As already announced here: viewtopic.php?f=2&t=218204

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sat Jun 06, 2020 1:31 am

straightlight wrote:
Fri Jun 05, 2020 9:56 pm
Can't reproduce the issue with the pre-release. Only v3.3.5 for bootstrap is showing.
If you look in admin/view/javascript/bootstrap/js/bootstrap.min.js the version is

Code: Select all

* Bootstrap v3.3.5 (http://getbootstrap.com)
Now look in admin/view/javascript/bootstrap/js/bootstrap.js the version is

Code: Select all

* Bootstrap v3.3.1 (http://getbootstrap.com)
This is from 3.0.3.4 downloaded 5 minutes ago
If the bootstrap.min.js is just the minified version of bootstrap.js then the versions should be the same yes/no
This is what OP means

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sat Jun 06, 2020 1:43 am

cyclops12 wrote:
Sat Jun 06, 2020 1:31 am
straightlight wrote:
Fri Jun 05, 2020 9:56 pm
Can't reproduce the issue with the pre-release. Only v3.3.5 for bootstrap is showing.
If you look in admin/view/javascript/bootstrap/js/bootstrap.min.js the version is

Code: Select all

* Bootstrap v3.3.5 (http://getbootstrap.com)
Now look in admin/view/javascript/bootstrap/js/bootstrap.js the version is

Code: Select all

* Bootstrap v3.3.1 (http://getbootstrap.com)
This is from 3.0.3.4 downloaded 5 minutes ago
If the bootstrap.min.js is just the minified version of bootstrap.js then the versions should be the same yes/no
This is what OP means
I just looked into the min.js extension files and it shows 3.3.5 as 2 results in those files.

Code: Select all

/*!
 * Bootstrap v3.3.5 (http://getbootstrap.com)
 * Copyright 2011-2015 Twitter, Inc.
 * Licensed under the MIT license
 */

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sat Jun 06, 2020 1:48 am

The catalog files are the same version but the admin files are different versions

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sat Jun 06, 2020 1:58 am

See this screenshot.

Attachments

bootstrap_results.png

bootstrap_results.png (11.9 KiB) Viewed 1742 times


Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sat Jun 06, 2020 2:17 am

That is admin and catalog i and the OP are talking about the two files in admin NOT catalog

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sat Jun 06, 2020 2:24 am

cyclops12 wrote:
Sat Jun 06, 2020 2:17 am
That is admin and catalog i and the OP are talking about the two files in admin NOT catalog
Both folders are showing in the screenshot with the same keyword for 3.3.5.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sat Jun 06, 2020 2:29 am

Your not reading the posts properly
Your screenshot shows admin/view/javascript/bootstrap/js and catalog/view/javascript/bootstrap/js files
We are talking about ADMIN/view/javascript/bootstrap/js/bootstrap.min.js and ADMIN/view/javascript/bootstrap/js/bootstrap.js

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sat Jun 06, 2020 3:27 am

Ok, found it. Unfortunately, JS files won't be upgraded with the pre-release version we have. It will have to be done later.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 77 guests