Post by straightlight » Sun Jun 21, 2020 10:14 pm

xxvirusxx wrote:
Sun Jun 21, 2020 9:32 pm
leafo/scssphp should be replaced with scssphp/scssphp because is abandoned.

https://packagist.org/packages/leafo/scssphp
Ok, package updated.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 22, 2020 11:28 am

Package updated.

* New Features from Master Branch *

- Replaced both startup folders
- Replaced session library files
- Replaced URL library
- Added language query on all URLs as per master branch
- Replaced system/engine
- Removed referential arrays to use one array with getTotal as per master branch
- Replaced catalog common language and currency controller with the master branch version
- Removed all true cases from $this->url->link as per master branch

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by sw!tch » Mon Jun 22, 2020 5:33 pm

opencart-3.0.3.4-features-pre is this the one we should be testing?

Search any keyword.. get the following.

Notice: Array to string conversion in catalog/controller/product/search.php on line 121

Code: Select all

$$data['breadcrumbs'][] = array(
to

Code: Select all

$data['breadcrumbs'][] = array(

Add to Wishlist on the category page is throwing a Warning as well. Didn't have time to look into this one.

Code: Select all

SyntaxError: JSON Parse error: Unrecognized token '<'
<b>Notice</b>: Only variables should be passed by reference in <b>catalog/controller/account/wishlist.php</b> on line <b>154</b><b>Warning</b>: str_replace() expects at most 4 parameters, 6 given in <b>
Also getting dropped sessions --
Looks like a new session ID is being inserted on each page refresh. I had 50+ sessions in the session table in a 2 minute test. This was fresh install, clean DB. See if you can replicate on your end.

Backup and [ learn how to recover ] before you make any changes.


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm

Post by straightlight » Mon Jun 22, 2020 8:08 pm

sw!tch wrote:
Mon Jun 22, 2020 5:33 pm
opencart-3.0.3.4-features-pre is this the one we should be testing?

Search any keyword.. get the following.

Notice: Array to string conversion in catalog/controller/product/search.php on line 121

Code: Select all

$$data['breadcrumbs'][] = array(
to

Code: Select all

$data['breadcrumbs'][] = array(

Add to Wishlist on the category page is throwing a Warning as well. Didn't have time to look into this one.

Code: Select all

SyntaxError: JSON Parse error: Unrecognized token '<'
<b>Notice</b>: Only variables should be passed by reference in <b>catalog/controller/account/wishlist.php</b> on line <b>154</b><b>Warning</b>: str_replace() expects at most 4 parameters, 6 given in <b>
Also getting dropped sessions --
Looks like a new session ID is being inserted on each page refresh. I had 50+ sessions in the session table in a 2 minute test. This was fresh install, clean DB. See if you can replicate on your end.
Please post in the right topic!

Your post has now been moved to the features.

Regarding the $breadcrumbs and str_replace issue with wishlist, these issues have now been fixed.

As for the sessions, you'll have to be more specific. Please provide more info.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 22, 2020 9:39 pm

Package updated.

- Fixed account/wishlist and product/search.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by sw!tch » Tue Jun 23, 2020 5:47 am

When you add a non-numeric value to qty on the product page. It comes up added to cart, however the item is not actually added. Makes sense to have some sort of json response passed back "Please enter a valid qty".

Users shopping may think the product was added from a simple typo and hence the product actually never was.

Further, you can enter negative values from the qty field, it will subtract QTY from existing cart items, shouldn't it be only positive integers?

Backup and [ learn how to recover ] before you make any changes.


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm

Post by straightlight » Tue Jun 23, 2020 6:09 am

sw!tch wrote:
Tue Jun 23, 2020 5:47 am
When you add a non-numeric value to qty on the product page. It comes up added to cart, however the item is not actually added. Makes sense to have some sort of json response passed back "Please enter a valid qty".

Users shopping may think the product was added from a simple typo and hence the product actually never was.

Further, you can enter negative values from the qty field, it will subtract QTY from existing cart items, shouldn't it be only positive integers?
Codes and locations to reproduce?

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by sw!tch » Tue Jun 23, 2020 7:21 am

straightlight wrote:
Tue Jun 23, 2020 6:09 am
Codes and locations to reproduce?
Actually just found a reference on GitHub - See here - https://github.com/opencart/opencart/pu ... f4a245c8b2

Backup and [ learn how to recover ] before you make any changes.


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm

Post by straightlight » Tue Jun 23, 2020 7:59 am

sw!tch wrote:
Tue Jun 23, 2020 7:21 am
straightlight wrote:
Tue Jun 23, 2020 6:09 am
Codes and locations to reproduce?
Actually just found a reference on GitHub - See here - https://github.com/opencart/opencart/pu ... f4a245c8b2
The only problem with these lookup are the remote API scripts that can already capture the cart's data.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Wed Jun 24, 2020 5:28 am

Can anybody please provide updates regarding session stability since the last update? Is it cutting off for anyone else? If so, please look at the integration process for possible improvement based on the provided change logs.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by sw!tch » Wed Jun 24, 2020 11:43 am

straightlight wrote:
Wed Jun 24, 2020 5:28 am
Can anybody please provide updates regarding session stability since the last update? Is it cutting off for anyone else? If so, please look at the integration process for possible improvement based on the provided change logs.
Seems the Admin side works fine, catalog side won't keep the session.

Just reinstalled and tested again. Added an item to the cart, go to the shopping cart page and comes up empty with some oddly formatted text "No results". The session table in the DB just keeps inserting new records on every refresh.

Will try and debug if I have time, nobody else is getting this?

Backup and [ learn how to recover ] before you make any changes.


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm

Post by straightlight » Thu Jun 25, 2020 11:36 pm

There will be a short delay for the next update of the features-pre due to the core-pre's latest update size that was required. An update will be posted shortly.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Fri Jun 26, 2020 1:19 am

Why leafo was restored?

OC 2.3.0.2 | OC 3.0.3.6 | Extensions converted by me | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Fri Jun 26, 2020 1:55 am

xxvirusxx wrote:
Fri Jun 26, 2020 1:19 am
Why leafo was restored?
Because the deprecation you were referring has been deprecated from the source for security reasons, not for features reason.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România
Who is online

Users browsing this forum: No registered users and 8 guests