Post by straightlight » Fri Jun 12, 2020 4:20 am

This topic is useful for users reporting feature issues from the master branch being integrated on the pre-release version of Opencart v3.0.3.4.

Note: This topic is only about the features from the master branch being integrated into the pre-release version of Opencart 'features' ZIP / TAR files.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 14, 2020 9:55 am

- Modified VERSION for 3.0.3.4-features-pre .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Thu Jun 18, 2020 10:35 am

- Fixed emails x of y from admin/controller/marketing/contact.php file as per this commit: https://github.com/opencart/opencart/pu ... cb8ff10374 .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Fri Jun 19, 2020 9:18 pm

Package updated.

- Modified catalog/controller/startup/startup.php with setcookie function to use same site strict.
- Using priority field for tax class under the admin.
- Added sort order with product options query model under the admin.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Fri Jun 19, 2020 11:38 pm

straightlight wrote:
Fri Jun 19, 2020 9:18 pm
- Modified catalog/controller/startup/startup.php with setcookie function to use same site strict.
See https://github.com/opencart/opencart/is ... -646193666 for why setting SameSite=Strict might be a bad idea.

www.add-creative.co.uk


Expert Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Fri Jun 19, 2020 11:57 pm

ADD Creative wrote:
Fri Jun 19, 2020 11:38 pm
straightlight wrote:
Fri Jun 19, 2020 9:18 pm
- Modified catalog/controller/startup/startup.php with setcookie function to use same site strict.
See https://github.com/opencart/opencart/is ... -646193666 for why setting SameSite=Strict might be a bad idea.
Unconfirmed at this time by Daniel. Awaiting confirmation on that.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sat Jun 20, 2020 2:26 am

straightlight wrote:
Fri Jun 19, 2020 11:57 pm
ADD Creative wrote:
Fri Jun 19, 2020 11:38 pm
straightlight wrote:
Fri Jun 19, 2020 9:18 pm
- Modified catalog/controller/startup/startup.php with setcookie function to use same site strict.
See https://github.com/opencart/opencart/is ... -646193666 for why setting SameSite=Strict might be a bad idea.
Unconfirmed at this time by Daniel. Awaiting confirmation on that.
Ok, found it in the master branch. Will update today.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sat Jun 20, 2020 3:03 am

Update old TWIG version to at least 2.12.5

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sat Jun 20, 2020 3:07 am

xxvirusxx wrote:
Sat Jun 20, 2020 3:03 am
Update old TWIG version to at least 2.12.5
Any commands without hidden tokens to set to provide with the composer?

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sat Jun 20, 2020 8:14 am

Package updated.

- Added the oc_setcookie function as per the master branch.

@Add Creative: While it may not be the best suitable solution, at least it will be more opted for the master branch in case better consideration becomes involved in the future rather than leaving it to the lower setting with the setcookie. I am currently looking on integrating the sessions into both startup files as per the master branch in order to try again with the newest password algorithm for the logins and the database and further oc_setcookie. Right now, we can't really go further with the oc_setcookie without fully integrating the session name solution into the startups.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by JNeuhoff » Sat Jun 20, 2020 7:35 pm

xxvirusxx wrote:
Sat Jun 20, 2020 3:03 am
Update old TWIG version to at least 2.12.5
Agreed, update Twig, and also use 'auto_reload' by default.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by straightlight » Sat Jun 20, 2020 7:48 pm

JNeuhoff wrote:
Sat Jun 20, 2020 7:35 pm
xxvirusxx wrote:
Sat Jun 20, 2020 3:03 am
Update old TWIG version to at least 2.12.5
Agreed, update Twig, and also use 'auto_reload' by default.
Any suggestions with the composer command line to upgrade? Daniel's version of this is it doesn't require hidden tokens to achieve this.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sat Jun 20, 2020 8:52 pm

Package updated

- Fixed catalog/view/theme/default/template/checkout/guest.twig file (required field with .parent() was leading to <fieldset> with postcode. Anybody can confirm that?)

- Fixed admin/view/template/sale/order_list.twig (added .table-response JS codes to fix bs.dropdown click menu)

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 21, 2020 1:42 am

Package updated.

- Added license check in admin/view/template/marketplace/marketplace_info.twig and marketplace_list.twig
- Added CONCAT invoice prefix date in install/opencart.sql ; oc_setting table

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun Jun 21, 2020 2:02 am

straightlight wrote:
Sat Jun 20, 2020 7:48 pm
Any suggestions with the composer command line to upgrade? Daniel's version of this is it doesn't require hidden tokens to achieve this.
Is weird as programmer to ask a hardware guy...
What I used
composer.json

Code: Select all

{
    "require": {
        "cardinity/cardinity-sdk-php": "^2.1.0",
        "braintree/braintree_php": "5.1.0",
        "scssphp/scssphp": "1.1.1",
        "divido/divido-php": ">=1.1.1",
        "klarna/kco_rest": "^4.2.3",
        "php": ">=7.1.0",
        "zoujingli/wechat-php-sdk": ">=1.3.10",
        "twig/twig": "2.12.5",
        "guzzlehttp/guzzle": "^6.5.4",
		"twbs/bootstrap":"4.0.0"
    }
}
https://github.com/condor2/Opencart_303 ... ae20e9c97f

composer update

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun Jun 21, 2020 3:10 am

What the hardware guy must also consider, part of these instructions, are showing the removal of system/library/template/twig.php file. However, not sure if this must be done before or after running the composer update.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 21, 2020 8:40 am

Package updated.

Alright folks, the moment we have all waited for has arrived. TWIG Engine has now been upgraded and available for the features-pre . Should we require another upgrade, let's test this TWIG version first and we'll go from there.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun Jun 21, 2020 3:25 pm

Features-PRE

- Update view function with master branch to load installer template
system/engine/loader

- change php version in step_2.twig from installer

Code: Select all

                <td>5.4+</td>
                <td class="text-center">{% if php_version >= '5.4' %}

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun Jun 21, 2020 8:31 pm

xxvirusxx wrote:
Sun Jun 21, 2020 3:25 pm
Features-PRE

- Update view function with master branch to load installer template
system/engine/loader

- change php version in step_2.twig from installer

Code: Select all

                <td>5.4+</td>
                <td class="text-center">{% if php_version >= '5.4' %}
Package updated.

- Fixed system/engine/loader.php (view only and added the Library title underneath that seemed to be missing).
- Fixed the admin SAAS startup controller and admin/view/stylesheet folder due to causing crash of the admin layout.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun Jun 21, 2020 9:32 pm

leafo/scssphp should be replaced with scssphp/scssphp because is abandoned.

https://packagist.org/packages/leafo/scssphp

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România
Who is online

Users browsing this forum: integraa and 38 guests