Page 1 of 2

Opencart 3.0.3.5 vqmod not work with twig files

Posted: Mon Jul 20, 2020 1:01 am
by aleopencart
In OpenCart v. 3.0.3.5 vqmod works partially (I have disabled cache with admin panel). Rewrite php files but doesn't work with twig files.

I have tested the following versions of vqmod for OpenCart with same result:
vqmod 2.6.1, 2.6.3, 2.6.4

In OpenCart v. 3.0.3.3 vqmod works correctly on both php and twig files.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Mon Jul 20, 2020 2:27 am
by IP_CAM
Well, it might no longer accept VqMod, what it should have been doing since OC v.2.0,
it would have kept thousands of Newbies from screwing up. But you're talking about a
Test version anyway, OC 3.0.3.5 is an Pre-Release Edition, so, playing around with it is for
Testers, and they comment on such matters on Github /OC only, since nobody cares about here ;)
Ernie
---
UPDATE: In contrary to some infos I've seen, OC 3.0.3.5 is already published for
Download on the official OC Site: ::) :choke:
Sorry about this, I was not aware of that. But there was a lot of action on Github OC today,
so, I assume, they updated/fixed a lot of Code ... ;)

Image

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Mon Jul 20, 2020 2:17 pm
by aleopencart
Thank you so much IP_CAM!

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Mon Jul 20, 2020 7:48 pm
by imakeitwork
It does seem to be an issue.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Wed Jul 22, 2020 7:09 pm
by aleopencart
Same problem with 3.0.3.6 release ???

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Wed Jul 22, 2020 7:50 pm
by xxvirusxx
3.0.3.6 was released so fast....that package should be updated by Daniel.

Download new files from here
https://github.com/opencart/opencart/tr ... aintenance

Then apply this
https://github.com/opencart/opencart/pull/8106/files

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Wed Jul 22, 2020 10:13 pm
by aleopencart
xxvirusxx wrote:
Wed Jul 22, 2020 7:50 pm
3.0.3.6 was released so fast....that package should be updated by Daniel.

Download new files from here
https://github.com/opencart/opencart/tr ... aintenance

Then apply this
https://github.com/opencart/opencart/pull/8106/files
I'm sorry but it doesn't solve the problem ..

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 1:05 am
by xxvirusxx
aleopencart wrote:
Wed Jul 22, 2020 10:13 pm
I'm sorry but it doesn't solve the problem ..
More info, logs etc...

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 2:30 am
by aleopencart
xxvirusxx wrote:
Thu Jul 23, 2020 1:05 am
aleopencart wrote:
Wed Jul 22, 2020 10:13 pm
I'm sorry but it doesn't solve the problem ..
More info, logs etc...


1. Download package "opencart-3.0.x.x_Maintenance.zip" from the link that you gave me
2. Apply https://github.com/opencart/opencart/pull/8106/files to "twig.php"

Replace this:

Code: Select all

			$loader = new \Twig\Loader\ArrayLoader(array($filename . '.twig' => $code));
Whit this:

Code: Select all

			$loader1 = new \Twig\Loader\ArrayLoader(array($filename . '.twig' => $code));
			$loader2 = new \Twig\Loader\FilesystemLoader(array(DIR_TEMPLATE)); // to find further includes
			$loader = new \Twig\Loader\ChainLoader(array($loader1, $loader2));
3. I have tried to install but give this error:
Warning: require(system/storage/vendor/composer/../react/promise/src/functions_include.php): failed to open stream: No such file or directory in system/storage/vendor/composer/autoload_real.php on line 69

In "system/storage/vendor/composer/autoload_real.php":

Code: Select all

	Line 66: function composerRequirea8cb75283b86ff94542c6f1327c4ce59($fileIdentifier, $file)
	Line 67: {
	Line 68:     if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) {
	Line 69:         require $file;
	Line 70: 
	Line 71:         $GLOBALS['__composer_autoload_files'][$fileIdentifier] = true;
	Line 72:     }
	Line 73: }
4. I have replace all upload folder of "opencart-3.0.x.x_Maintenance.zip" with upload folder of "opencart-3.0.3.6.zip" release and i finish to install OpenCart.

5. Replace all upload folder of "opencart-3.0.3.6.zip" with upload folder of "opencart-3.0.x.x_Maintenance.zip" and I replaced the file " upload/system/library/template/twig.php" with modifify file as suggestion in https://github.com/opencart/opencart/pull/8106/files

6. I tried to use VQMOD but rewrite php files and not twig files. No error in log folder system and log folder VQMOD.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 9:35 am
by letxobnav
ah, you are now alpha testing, perhaps that was the purpose of those releases afterall.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 2:33 pm
by aleopencart
letxobnav wrote:
Thu Jul 23, 2020 9:35 am
ah, you are now alpha testing, perhaps that was the purpose of those releases afterall.

No, I just tried what xxvirusxx suggested. The problem of missing VQMOD rewrite of the twig files on 3.0.3.5 and 3.0.3.6 releases remains.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 4:21 pm
by thekrotek
Not only VQMod isn't working on the latest OC releases, but OCMod as well. I mean, template files. I can see modifications applied in "modification" folder, but they don't seem to be actually working since another folder is used for caching template. Nice...

For me it was a broken system/modification.xml file. I downloaded it from the maintenance release and simply replaced the original file from 3.0.3.6.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 5:11 pm
by aleopencart
thekrotek wrote:
Thu Jul 23, 2020 4:21 pm
Not only VQMod isn't working on the latest OC releases, but OCMod as well. I mean, template files. I can see modifications applied in "modification" folder, but they don't seem to be actually working since another folder is used for caching template. Nice...

For me it was a broken system/modification.xml file. I downloaded it from the maintenance release and simply replaced the original file from 3.0.3.6.
Thank you thekrotek, but this valid only for ocmod modifications. For vqmod remain same problem...

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 5:23 pm
by thekrotek
aleopencart wrote:
Thu Jul 23, 2020 5:11 pm
Thank you thekrotek, but this valid only for ocmod modifications. For vqmod remain same problem...
If you don't have much VQMod files, I suggest you to convert them to OCMod since it isn't that hard to do.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 5:32 pm
by aleopencart
thekrotek wrote:
Thu Jul 23, 2020 5:23 pm
aleopencart wrote:
Thu Jul 23, 2020 5:11 pm
Thank you thekrotek, but this valid only for ocmod modifications. For vqmod remain same problem...
If you don't have much VQMod files, I suggest you to convert them to OCMod since it isn't that hard to do.
Yes thekrotek, this is not a problem. But I preferred to use vqmod. I hope that the developer don't want to abandon vqmod. I think it's a bad thing ....

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Thu Jul 23, 2020 5:52 pm
by thekrotek
I doubt the issue is with OpenCart. Most likely you need to ask VQMod parser developer about it.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Fri Jul 24, 2020 9:01 pm
by xxvirusxx
Checked now.

Code: Select all

<file name="system/library/template/Twig/*.php" error="skip">
and

Code: Select all

<file name="system/library/template/Twig/Loader/*.php" error="skip">
Twig folder was moved in storage folder.

LE. Maybe Qphoria will make a new release.
https://github.com/vqmod/vqmod/issues/159

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Fri Jul 24, 2020 9:55 pm
by JNeuhoff
Once you fix the 'modification.xml', our Integrated VQmod should work just fine for OpenCart 3.0.3.5 and 3.0.3.6! I just tested it for OpenCart 3.0.3.6.

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Sat Jul 25, 2020 2:08 am
by aleopencart
JNeuhoff wrote:
Fri Jul 24, 2020 9:55 pm
Once you fix the 'modification.xml', our Integrated VQmod should work just fine for OpenCart 3.0.3.5 and 3.0.3.6! I just tested it for OpenCart 3.0.3.6.
Please what's the fix for the modification.xml file that you have tested?

Re: Opencart 3.0.3.5 vqmod not work with twig files

Posted: Sat Jul 25, 2020 2:52 am
by IP_CAM
JNeuhoff's Integrated VQmod add's the modified Code to the Database, exactly like OcMods are 'handled',
instead of placing such Files in a Vqmod/Vqcache/ Subdirectory. It's probably the best and most efficient way of all,
since it avoids additional tasks, in order to create a Page. Not to speak about ERRORS, due to two Systems, unable
to communicate with each other, as VqMod and OcMod 'combined' should do, or better, cannot do. ;)
So, if you still use VqMods, for whatever unknown reason ever, use Integrated VQmod, you're better off ... ;)
Ernie
---
Integrated VQmod for OpenCart
https://www.opencart.com/index.php?rout ... n_id=19501