PHP mysqli connect_error() Function ERROR SHOW PASSWORD AND USERNAME

Code: Select all

trigger_error('Error: Could not make a database link (' .... 

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<modification>
<id><![CDATA[Database Security Fix]]></id>
<version><![CDATA[OC v.1.5.6.5]]></version>
<vqmver><![CDATA[2.6.1]]></vqmver>
<author><![CDATA[open-cat - IP_CAM]]></author>
<email><![CDATA[webmaster@opencart.li]]></email>
<link><![CDATA[http://www.opencart.li]]></link>

<file name="system/database/mysqli.php">
<operation error="log">
<search position="replace"><![CDATA[trigger_error('Error: Could not make a database link (' . $this->link->connect_errno . ') ' . $this->link->connect_error);]]></search>
<add><![CDATA[die('Unable to connect to database');]]></add>
</operation>
<operation error="log">
<search position="replace"><![CDATA[trigger_error('Error: ' . $this->link->error . '<br />Error No: ' . $this->link->errno . '<br />' . $sql);]]></search>
<add><![CDATA[die('Unable to connect to database');]]></add>
</operation>
</file>
</modification>

Code: Select all

	public function __construct($adaptor, $hostname, $username, $password, $database, $port = NULL) {
		$class = 'DB\\' . $adaptor;
		if (class_exists($class)) {
			$this->adaptor = new $class($hostname, $username, $password, $database, $port);
			if (!$this->connected()) {
				error_log('DB Error: No Connection, sending static maintenance page');
				ob_start();
				include(DIR_INCLUDES.'maintenance-en.html');
				$maintenance_page = ob_get_clean();
				http_response_code(503);
				header('Retry-After: 300');
				echo $maintenance_page;
				exit();
			}
		} else {
			error_log('DB Error: Could not load database adaptor '.$adaptor.', sending static maintenance page');
			ob_start();
			include(DIR_INCLUDES.'maintenance-en.html');
			$maintenance_page = ob_get_clean();
			http_response_code(503);
			header('Retry-After: 300');
			echo $maintenance_page;
			exit();
		}
	}

Code: Select all

	public function __construct($hostname, $username, $password, $database, $port = '3306') {
		$this->connection = new \mysqli($hostname, $username, $password, $database, $port);
		if ($this->connection->connect_error !== NULL) {
				error_log('DB Error: [' . $this->connection->connect_error . '] No: [' . $this->connection->connect_errno.']');
		} else {
			$this->connection->set_charset("utf8");
			$this->connection->query("SET SQL_MODE = ''");
		}
	}

Code: Select all

[10-Oct-2020 03:57:52 UTC] DB Error: [No connection could be made because the target machine actively refused it.] No: [2002]
[10-Oct-2020 03:57:52 UTC] DB Error: No Connection, sending static maintenance page
and this:
[10-Oct-2020 03:58:52 UTC] DB Error: [Access denied for user 'root'@'127.0.0.1' (using password: YES)] No: [1045]
[10-Oct-2020 03:58:52 UTC] DB Error: No Connection, sending static maintenance page

Code: Select all

	if (!$this->db->connected()) {
		error_log('CCSS74: Error (01): Database not connected, maintenance page shown.');
		error_log($_SERVER['REMOTE_ADDR'].' '.$_SERVER['REQUEST_URI'].' '.$_SERVER['HTTP_USER_AGENT']);
		ob_start();
		include(DIR_INCLUDES.'maintenance-en.html');
		$maintenance_page = ob_get_clean();
		http_response_code(503);
		header('Retry-After: 300');
		echo $maintenance_page;
		exit();
	}

Code: Select all

	public function __construct($hostname, $username, $password, $database, $port = '3306') {
		try {
			mysqli_report(MYSQLI_REPORT_STRICT);
			$this->connection = @new \mysqli($hostname, $username, $password, $database, $port);
		} catch (\mysqli_sql_exception $e) {
			// what's in $e
			//print_r($e);
			// only show error message, died anyway
			//die($e->getMessage());
			// or throw new exeption and see how OC handles it: Dies with all login info shown on sccreen !!!!!!
			throw new \Exception('Error: Could not make a database link using ' . $username . '@' . $hostname . '!');
		}
		$this->connection->set_charset("utf8");
		$this->connection->query("SET SQL_MODE = ''");
	}

Code: Select all

				$this->connection = new \mysqli($hostname, $username, $password, $database, $port);

		if ($this->connection->connect_error) {
			die ('Error: Could not make a database link'); // still shows username @ server !!!!! Have to use Try !!!
			//throw new \Exception('Error: ' . $this->connection->error . '<br />Error No: ' . $this->connection->errno);
		}

Code: Select all

die('Error: Could not make a database link!');